WASAPI: Improve how default devices are created to support automatic stream routing #754
+202
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able automatic stream routing in case the default device changes
# Conflicts: # Cargo.toml # src/host/wasapi/device.rs
|
Will the pr be merged? The feature is quite important to handle device changes IMO. |
# Conflicts: # Cargo.toml # src/host/wasapi/device.rs
|
@est31 I would personally be able to revive/bring this PR forward if you have time to review - no worries if not. |
9 tasks
|
@jacksongoode please, tell me your opinion on it. |
|
@est31 I guess I'm wondering if there's anything blocking on this or if we could get a review from a maintainer? I'd be happy to make changes with a review from someone more familiar with this library. |
|
Thank you for working on this PR! I'm switching my app to use it, hopefully it gets upstreamed someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ActivateAudioInterfaceAsyncto create default input/output devices to support automatic stream routing.Related issues: #740
Open questions: